Downgrade: raise SciMLBase compat floor to 2.34#113
Merged
ChrisRackauckas merged 1 commit intoJun 15, 2026
Conversation
…le at downgrade minimum) At the downgrade minimum, the root SciMLBase floor 2.0 resolves to SciMLBase 2.0.x, whose ADTypes compat is 0.1.3-0.2, so the resolver pins ADTypes to 0.2.7. The test environment (test/Project.toml) declares ADTypes = "1.1", giving "empty intersection between ADTypes@0.2.7 and project compatibility 1.1.0-1". SciMLBase 2.34.0 is the first release whose ADTypes compat admits 1.x (ADTypes = ["0.2.5-0.2", "1"]), so bumping the floor lets ADTypes resolve to >=1 and matches the test floor. 2.34 is the smallest SciMLBase floor that resolves. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MINIMUM-VERSION downgrade resolve failure
The
Downgradeworkflow fails (latest failing run 27462277554) with:Conflicting pin / why the old floor was impossible
At the downgrade minimum the resolver pins the root dep
SciMLBaseto its 2.0 floor. SciMLBase 2.0.x declaresADTypes = "0.1.3-0.2", so the downgrade manifest pins ADTypes 0.2.7. The test environment (test/Project.toml) declaresADTypes = "1.1", so the subsequentPkg.testre-resolve sees ADTypes 0.2.7 against the test compat1.1.0-1→ empty intersection.SciMLBase only began admitting
ADTypes1.x at 2.34.0 (compat["0.2.5-0.2", "1"]); every SciMLBase< 2.34.0is restricted to ADTypes0.2.x. So the old floorSciMLBase = "2, 3.1"was never co-installable with the package's own modern test stack (which requires ADTypes>= 1.1).Fix
Raise the
SciMLBasefloor to 2.34 (SciMLBase = "2.34, 3.1") — the first SciMLBase release that admits ADTypes 1.x. Lower-bound raise only; the upper structure (3.1) and all test logic are unchanged.Resolve verification (local, Julia 1.10 lts floor, Resolver.jl
--min=@deps)SciMLBase = "2, 3.1"→ manifest pins SciMLBase 2.0.x, ADTypes 0.2.7 → reproduces the empty-intersection against the test ADTypes1.1floorSciMLBase = "2.34, 3.1"→ manifest pins SciMLBase 2.34.0, ADTypes 1.22.0 (∈ test compat1.1) → conflict eliminatedNote: the package's regular (latest-versions)
Testsfailure onmainis a separate, unrelated issue (JET 0.11.x requiring a newer Julia onlts, plus a SparseDiffTools/SciMLOperators conflict), not addressed here.This PR should be ignored until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code